Skip to content

Conversation

@labkey-willm
Copy link
Contributor

@labkey-willm labkey-willm commented Feb 5, 2025

Rationale

https://github.com/LabKey/kanban/issues/362

We are consolidating where we are defining our default Content Security Policy, and making 'enforce' the default for most, if not all, deployments.

Related Pull Requests

Changes

  • add default 'enforce' csp with markers for automatically updating from source version in other repo
  • add wiring for LABKEY_OPTIONAL_APP_PROPERTIES_S3_URI
  • remove CSP_REPORT and CSP_ENFORCE env vars, as no longer needed
  • update README with these updates

@labkey-willm labkey-willm changed the title Fb_use_canonical_csp add default enforced Content Security Policy Feb 6, 2025
Copy link
Contributor

@labkey-stuartm labkey-stuartm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the ReadMe changes

"In can, however,"

This should be:
It can, however,

Co-authored-by: labkey-stuartm <32204841+labkey-stuartm@users.noreply.github.com>
@labkey-willm labkey-willm merged commit bdb09fd into develop Feb 14, 2025
5 checks passed
@labkey-willm labkey-willm deleted the fb_use_canonical_csp branch February 14, 2025 21:57
labkey-willm added a commit that referenced this pull request Feb 14, 2025
* add default csp.enforce block and ability to load an optional.application.properties

* remove CSP_REPORT and CSP_ENFORCE; update README

* add wiring for optional app properties file from s3

* update to match what's currently deployed

* Update README.md

Co-authored-by: labkey-stuartm <32204841+labkey-stuartm@users.noreply.github.com>

---------

Co-authored-by: labkey-stuartm <32204841+labkey-stuartm@users.noreply.github.com>
labkey-willm added a commit that referenced this pull request Feb 15, 2025
* add default csp.enforce block and ability to load an optional.application.properties

* remove CSP_REPORT and CSP_ENFORCE; update README

* add wiring for optional app properties file from s3

* update to match what's currently deployed

* Update README.md



---------

Co-authored-by: labkey-stuartm <32204841+labkey-stuartm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants