Relocate methods related to file name uniqueness to FileUtil
#370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Jul 28, 2025
labkey-adam
reviewed
Jul 31, 2025
| public @Nullable Double getSchemaVersion() | ||
| { | ||
| return 23.000; | ||
| return 25.000; |
There was a problem hiding this comment.
@labkey-susanh was this schema bump necessary for some reason?
Author
There was a problem hiding this comment.
No. I had thought so initially, but it wasn't. Is it causing issues?
There was a problem hiding this comment.
No, just unusual for us to be bumping versions in modules we don't manage. If deployed without any other upgrading modules, it will cause a no-op "upgrade" (drop and recreate all views), but that's harmless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Since there's nothing specific about assays in the
findUniqueFileNamemethod (and relatives), they are better located in theFileUtilclass thanAssayFileWriter.Related Pull Requests
Changes
findUniqueFileNamemethod.