Skip to content

Return Set<Class<?>> from Module "get test" methods #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 1 commit into from
Oct 3, 2025
Merged

Return Set<Class<?>> from Module "get test" methods #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions hivrc/src/org/labkey/hivrc/HivrcModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
import org.jetbrains.annotations.Nullable;
import org.labkey.api.data.Container;
import org.labkey.api.ldk.ExtendedSimpleModule;
import org.labkey.api.module.Module;
import org.labkey.api.module.ModuleContext;
import org.labkey.api.query.DefaultSchema;
import org.labkey.api.query.QuerySchema;
import org.labkey.api.util.HtmlString;
import org.labkey.api.view.BaseWebPartFactory;
import org.labkey.api.view.HtmlView;
Expand Down Expand Up @@ -53,7 +49,7 @@ protected Collection<WebPartFactory> createWebPartFactories()
new BaseWebPartFactory("HIVRC Analysis Header")
{
@Override
public WebPartView getWebPartView(@NotNull ViewContext portalCtx, @NotNull Portal.WebPart webPart)
public WebPartView<?> getWebPartView(@NotNull ViewContext portalCtx, @NotNull Portal.WebPart webPart)
{
if (!portalCtx.getContainer().isWorkbook())
{
Expand Down
2 changes: 1 addition & 1 deletion mGAP/src/org/labkey/mgap/mGAPModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ public JSONObject getPageContextJson(ContainerUser context)
}

@Override
public @NotNull Set<Class> getUnitTests()
public @NotNull Set<Class<?>> getUnitTests()
{
return PageFlowUtil.set(mGapReleaseGenerator.TestCase.class);
}
Expand Down
8 changes: 1 addition & 7 deletions mGAP/src/org/labkey/mgap/mGapAuditTypeProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,7 @@ public class mGapAuditTypeProvider extends AbstractAuditTypeProvider implements

public mGapAuditTypeProvider()
{

}

@Override
protected AbstractAuditDomainKind getDomainKind()
{
return new mGapAuditTypeProvider.AuditDomainKind();
super(new mGapAuditTypeProvider.AuditDomainKind());
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion primeseq/src/org/labkey/primeseq/PrimeseqModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public PipelineStartup()
}

@Override
public @NotNull Set<Class> getUnitTests()
public @NotNull Set<Class<?>> getUnitTests()
{
return PageFlowUtil.set(ClusterMaintenanceTask.TestCase.class);
}
Expand Down