Handle failure when too much metadata is stored in FITS or HDF#136
Open
joezuntz wants to merge 4 commits into
Open
Handle failure when too much metadata is stored in FITS or HDF#136joezuntz wants to merge 4 commits into
joezuntz wants to merge 4 commits into
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
========================================
+ Coverage 83.8% 84.2% +0.4%
========================================
Files 17 17
Lines 1667 1682 +15
Branches 294 297 +3
========================================
+ Hits 1397 1417 +20
+ Misses 188 183 -5
Partials 82 82
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FITS files do not allow more than 1000 columns, and HDF files don't have a hard limit but fail when the header size gets too high, which can happen a little above 1000 for reasonable size names. This splits long metadata tables (which have one column per metadata item to allow typing to work correctly) into multiples.
It is backwards compatible, and I've explicitly added data files from the previous version so we can keep making sure of this.