fix(layout): push #footer to viewport bottom on content-short pages#7016
Open
edgarcosta wants to merge 1 commit into
Open
fix(layout): push #footer to viewport bottom on content-short pages#7016edgarcosta wants to merge 1 commit into
edgarcosta wants to merge 1 commit into
Conversation
Previously #footer floated wherever #main's content (with a fixed 600px min-height) ended, leaving large gaps mid-viewport on short pages such as /, /about, and /contact when viewed on tall windows. Switch to the standard flex sticky-footer pattern: a new #layout wrapper around the page content and footer is a flex column with min-height: 100vh, and an inner #page-wrapper grows to fill any remaining space, so #footer naturally lands at the bottom of the viewport on short pages and continues to flow after content on long pages. No magic numbers, no per-page tuning. The flex container is a dedicated wrapper rather than body itself because third-party scripts (reCAPTCHA) append elements to body, and those should not become flex items that displace the footer. Verified with playwright across /, /about, /contact at viewport heights 1080, 1440, 2000: footer's bottom edge is at the viewport bottom on every page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously #footer floated wherever #main's content (with a fixed 600px min-height) ended, leaving large gaps mid-viewport on short pages such as /, /about, and /contact when viewed on tall windows.
Switch to the standard flex sticky-footer pattern: a new #layout wrapper around the page content and footer is a flex column with min-height: 100vh, and an inner #page-wrapper grows to fill any remaining space, so #footer naturally lands at the bottom of the viewport on short pages and continues to flow after content on long pages. No magic numbers, no per-page tuning.
The flex container is a dedicated wrapper rather than body itself because third-party scripts (reCAPTCHA) append elements to body, and those should not become flex items that displace the footer.
Verified with playwright across /, /about, /contact at viewport heights 1080, 1440, 2000: footer's bottom edge is at the viewport bottom on every page.
See it on olive.lmfdb.xyz