Skip to content

Expand completeness checker for elliptic curves and number fields#7014

Open
rvisser7 wants to merge 23 commits into
LMFDB:mainfrom
rvisser7:completeness
Open

Expand completeness checker for elliptic curves and number fields#7014
rvisser7 wants to merge 23 commits into
LMFDB:mainfrom
rvisser7:completeness

Conversation

@rvisser7
Copy link
Copy Markdown
Member

@rvisser7 rvisser7 commented May 16, 2026

This PR extends the completeness checker (lmfdb/utils/completeness.py) with a few more cases for elliptic curves, genus 2 curves, and number fields.

As always, any comments/feedback much appreciated! 🙂

I've also been adding various extra comments and docstrings throughout the completeness.py file, mainly for my own understanding of how everything works. I thought I'll keep them in as it might benefit others (but can also take them out if you'd think they're unnecessary).

rvisser7 added 22 commits May 12, 2026 23:58
@rvisser7 rvisser7 marked this pull request as ready for review May 17, 2026 17:23
@roed314
Copy link
Copy Markdown
Member

roed314 commented May 17, 2026

I need to focus on final exams for a few days, but I'll be happy to look this once I'm done!

@rvisser7
Copy link
Copy Markdown
Member Author

Thanks - of course no rush! I've realised there are many more cases we could still add, though I think the above is probably enough for this PR. :)

I've opened a separate issue #7017 to help track more cases we could add to the completeness checker in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants