Reformat lmfdb/templates/style.css for readability#7008
Open
roed-math wants to merge 1 commit into
Open
Conversation
Pure formatting cleanup of lmfdb/templates/style.css with no
intended change to rendered output. Standardized:
- 4-space indentation throughout (was a mix of 2/4 spaces)
- Opening brace on same line as selector with a single space before
- Comma-separated selectors split onto their own lines
- One declaration per line, single space after the colon
- Consistent blank-line spacing between rules
- Section banner comments grouping related rules
No selectors, declarations, values, comments, or rule order were
changed. Verified that the multisets of selectors (427), property
declarations (1004), and Jinja `{{...}}` expressions (244) are
identical before and after.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
While we're cleaning up, it might make sense to fix inconsistencies in whitespace with jinja templates in this file: see e.g. line 2474 in the new file. |
Member
|
We should just write what style we want for Jinja and create a STYLE.md so we can try to follow it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure formatting cleanup of
lmfdb/templates/style.css. No selector, declaration, value, comment, or rule order is changed — the rendered output should be byte-identical.Standardized:
Verified that, before and after the change, the multisets of:
{{ ... }}expressions (244)are identical.
A separate follow-up PR will address the actual bugs and dead code surfaced while reading the file (missing commas in a multi-selector rule, invalid CSS values like
vertical-align: centerandalign-items: top, duplicatedspan.chargp/span.normgp/span.activesubgprules, etc.) so this PR stays trivially reviewable.Test plan
git diff --word-diffshows only whitespace, brace, and newline changes🤖 Generated with Claude Code