chore: retire next branch, main now drives staging deploys (CPL-272)#312
Merged
Merged
Conversation
Removes the next branch from deploy triggers and retires the chipotle-dev staging target. Main now deploys to chipotle-next / lit-static-next (inheriting the old next-branch behavior). Production deploys remain tag-driven via v* tags. - deploy-staging.yml, deploy-static.yml: trigger only on main; drop chipotle-dev and lit-static-dev paths; always use Stripe sandbox keys - phala-simulator, k6-client-check, contract-bindings-check, k6-smoke, k6-correctness, manual_contract-upgrade: branch/ref references switched from next to main - NodeConfig: consolidate next.toml into main.toml (chipotle-next contract); delete NodeConfig.next.toml - Dockerfile, Dockerfile.lit-api-server, justfile, justfile.sim: default NODE_CONFIG and branch-conditional lookups updated to main Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the repo’s deployment/CI branch flow so that main replaces the retired next branch as the staging deploy trigger, while keeping production deploys tag-driven (v*).
Changes:
- Update GitHub Actions workflows to trigger staging/static deploys and several checks from
mainonly. - Retire
NodeConfig.next.tomlby moving its contract address intoNodeConfig.main.toml, and update Docker/just scripts to default toNodeConfig.main.toml. - Simplify local/CI scripts that previously branched on
mainvsnext.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
lit-api-server/NodeConfig.next.toml |
Removes the retired next node config. |
lit-api-server/NodeConfig.main.toml |
Updates main config to use the former next contract address. |
justfile.sim |
Always copies NodeConfig.main.toml into the gitignored NodeConfig.toml. |
justfile |
Removes branch-conditional deploy vars; hard-codes staging target values. |
Dockerfile.lit-api-server |
Defaults NODE_CONFIG build arg to NodeConfig.main.toml. |
Dockerfile |
Defaults NODE_CONFIG build arg to NodeConfig.main.toml. |
.github/workflows/phala-simulator.yml |
Runs on main only; always uses NodeConfig.main.toml. |
.github/workflows/k6-smoke.yml |
Switches “next-vs-dev” selection logic to key off main. |
.github/workflows/k6-correctness.yml |
Switches “next-vs-dev” selection logic to key off main. |
.github/workflows/k6-client-check.yml |
Removes next from push trigger branches. |
.github/workflows/deploy-static.yml |
Removes next push trigger; points deploys at lit-static-next. |
.github/workflows/deploy-staging.yml |
Removes next push trigger; staging deploy target becomes chipotle-next; always uses Stripe sandbox keys. |
.github/workflows/contract-bindings-check.yml |
Removes next from push trigger branches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e-yml-files-for-deployment # Conflicts: # .github/workflows/deploy-staging.yml
Match the existing comment by reading PHALA_APP_NAME via env() instead of hard-coding chipotle-next. Per-developer overrides now work as documented. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: CPL-272
Implements the branch-flow migration from CPL-272. The
nextbranch is retired as a deploy trigger;mainnow drives staging deploys. Production stays tag-driven (v*→deploy-prod-1-propose.yml).Effect per user decision:
mainpush →chipotle-next(Phala) +lit-static-next(Cloudflare Pages)chipotle-dev/lit-static-devare retired — dev no longer gets deployedv*tag → production (unchanged)Deployment workflows
deploy-staging.yml: triggers only onmain; deploys tochipotle-next; Stripe always uses sandbox keysdeploy-static.yml: triggers only onmain; deploys tolit-static-nextwithtest.chipotle.litprotocol.com; PR preview repointed fromlit-static-dev→lit-static-nextCI/check workflows (next → main rename)
phala-simulator.yml,k6-client-check.yml,contract-bindings-check.yml:[main, next]→[main]k6-smoke.yml,k6-correctness.yml:github.ref_name == 'next'→'main'manual_contract-upgrade.yml: intentionally left unchanged (user reverted)Supporting files
NodeConfig.main.toml: contents replaced with the formernextconfig (chipotle-next contract0x98e5...)NodeConfig.next.toml: deletedDockerfile,Dockerfile.lit-api-server: defaultNODE_CONFIG→NodeConfig.main.tomljustfile,justfile.sim: branch-conditional lookups collapsed tomain-onlyTest plan
maintriggers deploy-staging →chipotle-next(notchipotle-dev)maintriggers deploy-static →lit-static-nextv*tag still triggersdeploy-prod-1-propose.yml(no regression)manual_contract-upgradeworkflow still runs (it was intentionally reverted — note: it references deletedNodeConfig.next.tomlwhennextis selected; follow-up may be needed)Known follow-ups (not in this PR)
manual_contract-upgrade.ymlstill offers anextbranch choice butNodeConfig.next.tomlis deleted — selectingnextwill fail until that workflow is reconciledk6/data/accounts.next.jsonandk6/justfilestill usenextnaming internally — not touched per scope🤖 Generated with Claude Code