Fix support markdown extension#190
Open
patrick-werner wants to merge 5 commits into
Open
Conversation
…in questionnaire processing
…ssing to support valueMarkdown
Contributor
Author
|
fixes #191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of FHIR
rendering-markdownextensions by adding support for both the correctvalueMarkdownand the legacyvalueStringkeys during import and export. It ensures that the original format is preserved and round-tripped correctly, and adds tests for this behavior.FHIR rendering-markdown support improvements:
getMarkdownExtensionValueininternal-utils.jsto extract markdown text from eithervalueMarkdownorvalueString, ensuring compatibility with both new and legacy FHIR data.sdc-import-common.jsto use the new utility, store the original markdown value and its type, and pass these through to the export logic. This preserves whether the source usedvalueMarkdownorvalueString. [1] [2] [3]sdc-export-common.jsto use the correct key (valueMarkdownorvalueString) based on the original import, ensuring round-trip fidelity. [1] [2]Testing:
valueMarkdownfor rendering-markdown, and a corresponding Karma test to verify correct import and export handling. [1] [2]