Skip to content

fix(ci): pass --no-git-checks to publish only#531

Merged
LGLabGreg merged 1 commit intomainfrom
ci/flags
May 9, 2026
Merged

fix(ci): pass --no-git-checks to publish only#531
LGLabGreg merged 1 commit intomainfrom
ci/flags

Conversation

@LGLabGreg
Copy link
Copy Markdown
Owner

@LGLabGreg LGLabGreg commented May 9, 2026

pnpm forwarded trailing flags to changeset tag, which rejected them.

Summary by CodeRabbit

  • Chores
    • Updated release process configuration to streamline the publishing workflow.

Review Change Stack

pnpm forwarded trailing flags to changeset tag, which rejected them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reactqrcode-com Ready Ready Preview, Comment May 9, 2026 2:54pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a7c3679a-4e51-4f9b-bb89-afa401a81a65

📥 Commits

Reviewing files that changed from the base of the PR and between 5af51bf and 261315b.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • package.json

Walkthrough

The --no-git-checks flag for the publish command is relocated from the GitHub Actions workflow step directly into the ci:publish script definition in package.json, consolidating flag management into the scripts file while maintaining the same publish behavior.

Changes

Publish Flag Relocation

Layer / File(s) Summary
Script Definition
package.json
The ci:publish script now includes --no-git-checks in the command: pnpm publish -r --no-git-checks.
Workflow Invocation
.github/workflows/release.yml
The Changesets action step calls pnpm ci:publish without the flag argument, delegating it to the script definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A flag moves home, from workflow to script so neat,
Less duplication makes the setup complete,
The --no-git-checks finds its rightful place,
Now workflows call clean, with elegant grace! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving the --no-git-checks flag from the workflow to the package.json script to apply it only to the publish step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/flags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LGLabGreg LGLabGreg merged commit 34b5a00 into main May 9, 2026
4 of 5 checks passed
@LGLabGreg LGLabGreg deleted the ci/flags branch May 9, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant