SendingObjectNametoSite

[mfitzasp]

Howdy champs. I am including this into the javascript so it sends an object name to the site. I have a string here 'test object' that just gets sent so I can test it. Do either of you know if "this.object_name" is the correct (or even existant!) variable to use to grab object name from the object boxes? Also do you have a testing site to see that this doesn't break stuff? No rush! When you want some cross-procrastination :)

[wrosing]

Which object name is correct begs the question. Multiple places in all the code seem to deal with names. I suggest that what you type into the name search box, and especially if that name resolves to coordinates that that be the CATNAME in the fits header. that came from a catalog. if it does not resolve then we take the user supplied RA and DEC and in a uniform way create a RA-DEc based "catname." A user can also give a name to an object -- intended to call that "OBJNAME" of something to that effect. "USERDESIGNATEDNAME" might be the better term -- but too long and confuses with the user's handle/name.! I also prefer TARGET over OBJECT but since I have been programming the latter tends to creep in ... What we should do is name the various variables in a clear way so we all know what is going on between the browser and the AWS Python code. I am not too fussy about this because some catalogs have all sorts of common (vulgar in Latin) names.

…

On Wed, Sep 14, 2022 at 10:08 PM mfitzasp ***@***.***> wrote: Howdy champs. I am including this into the javascript so it sends an object name to the site. I have a string here 'test object' that just gets sent so I can test it. Do either of you know if "this.object_name" is the correct (or even existant!) variable to use to grab object name from the object boxes? Also do you have a testing site to see that this doesn't break stuff? No rush! When you want some cross-procrastination :) ------------------------------ You can view, comment on, or merge this pull request online at: #54 Commit Summary - 32b1fea <32b1fea> adding in object to opt_params File Changes (1 file <https://github.com/LCOGT/ptr_ui/pull/54/files>) - *M* src/mixins/commands_mixin.js <https://github.com/LCOGT/ptr_ui/pull/54/files#diff-b7aedf7870a67fbc488c34232d09f20529e0d79e1e6e06ea17c26620a95b9d72> (2) Patch Links: - https://github.com/LCOGT/ptr_ui/pull/54.patch - https://github.com/LCOGT/ptr_ui/pull/54.diff — Reply to this email directly, view it on GitHub <#54>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACTZ3MCFFXP4N6PFUFUA6O3V6JEFBANCNFSM6AAAAAAQM2PU6Q> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Clear skies, Wayne Rosing Founder 805 452 3229 cell <<<NEW! Please do not give out widely. 805 880 1603 office Please note ***@***.*** is our preferred address.

[timbeccue]

Just an fyi, javascript comments are denoted by double backslashes for single lines or enclosed by backslash and star for longer ones. :)

// here is a single line comment

/* 
here is a 
multiline comment
*/
'''

[timbeccue]

Regarding testing environments: we originally had dev.photonranch.org separate from www.photonranch.org so that one could be used for safe experimentation. But dev ended up being the only updated version as of two months ago, not sure if that's still the case.

However, for testing something like this, running the frontend locally is probably the easiest option as you can see your changes live (as opposed to deploying the site every time you want to try something new).

I'm not sure if you ended up fixing this issue already, but let me know if not and I'd be happy to take a look!

[mfitzasp]

Yes, Sensei Katie and Sensei Darren showed me how to npm local serve. Thats what ive been using (although i did fling a couple of very simple edits to dev early on) We have fixed the object stuff. There is a big one from me due in a few hours to do with RA and Dec in projects and targets if you want to take a look when i push that up for review :)

…

On Wed, 21 Sep 2022, 7:39 am Tim Beccue, ***@***.***> wrote: Regarding testing environments: we originally had dev.photonranch.org separate from www.photonranch.org so that one could be used for safe experimentation. But dev ended up being the only updated version as of two months ago, not sure if that's still the case. However, for testing something like this, running the frontend locally is probably the easiest option as you can see your changes live (as opposed to deploying the site every time you want to try something new). I'm not sure if you ended up fixing this issue already, but let me know if not and I'd be happy to take a look! — Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAHGNWKKAO4S4IPL4BL5ODV7IVKRANCNFSM6AAAAAAQM2PU6Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>