+zipalign and apt clean #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry, I did not meant to add awscli to this same pullrequest. I use awscli to upload final apk to custom s3 bucket; however that last commit might not fit well on the scope of your image. Please feel free to ignore that last commit and instead do merge up to f4527b8. ((of course, if you find that awscli fits, please do merge it as well)) Saludos |
Kusumoto
approved these changes
Oct 30, 2019
Kusumoto
reviewed
Oct 30, 2019
| git \ | ||
| gradle \ | ||
| zipalign \ | ||
| awscli \ |
Owner
There was a problem hiding this comment.
Please remove awscli because this is not generic package for use this image.
|
Hi, I also need to sign the apk with zipalign, when will you add these libraries to master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
¡Hola!
Thanks for this image, it has been very helpful for me.
I noted it is missing zipalign and some apt cleanup steps; you may see benefit on merging them.