Task/jabs core and jabs io subpackages #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the JABS codebase into a workspace structure with three separate packages: jabs-behavior-classifier, jabs-core, and jabs-io. The refactoring extracts shared utilities, constants, enums, exceptions, and abstract base classes into jabs-core, while preparing jabs-io for future I/O functionality.
Changes:
- Created new workspace packages
jabs-coreandjabs-iowith dedicated pyproject.toml files - Moved shared code (utilities, constants, enums, exceptions, abstract classes) from
jabs-behavior-classifiertojabs-core - Updated all import statements across the codebase to reference the new package structure
- Configured uv workspace with namespace packages
Reviewed changes
Copilot reviewed 47 out of 59 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added workspace configuration and dependencies on new jabs-core and jabs-io packages |
| packages/jabs-core/pyproject.toml | Created new jabs-core package configuration |
| packages/jabs-io/pyproject.toml | Created new jabs-io package configuration |
| packages/jabs-core/src/jabs/core/* | Moved core utilities, constants, enums, exceptions, and abstract classes |
| src/jabs/**/*.py | Updated imports to reference jabs.core package |
| tests/**/*.py | Updated test imports to reference jabs.core package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request demonstrates one option for organizing the JABS packages, breaking a
jabs-coreandjabs-iopackage out into two new uv workspace packages.There is minimal refactoring included to demonstrate that cross-package imports still work, but the new workspace packages remain largely unimplemented.
Work to do(in this PR):
Work to do (after PR):
jabs-iopackagejabs-behavior-classifiercode to determine which should move to the new packages