Skip to content

Conversation

@gbeane
Copy link
Collaborator

@gbeane gbeane commented Jan 22, 2026

Pull Request: Refactor Settings Dialog and Related Improvements

Summary

This pull request introduces a refactor of the JABS settings dialog, along with related improvements and code cleanup. The primary focus is on modularizing the settings dialog architecture and removing unused code.

Key Changes

1. Settings Dialog Refactor

  • SettingsDialog is now an abstract base class, providing a foundation for specialized settings dialogs.
  • JabsSettingsDialog: New dialog for application-wide (JABS) settings (currently just enabling/disabling session tracking, which has been removed from the JABS menu).
  • ProjectSettingsDialog: New dialog for project-specific settings (former functionality contained in SettingsDialog).

2. Session Tracking Setting

  • The "Enable Session Tracking" option has been moved from the JABS menu to the new JabsSettingsDialog to avoid cluttering the menu with a rarely used setting (and to provide inline documentation)

3. Other Cleanup

  • Removed unused utility functions and cleaned up related imports.
  • Improved internal documentation and code comments.

Additional Notes

  • The settings dialog system is now more extensible, making it easier to add new settings groups and dialogs in the future.
  • The user experience for managing both application and project settings is improved, with a more consistent and discoverable interface.

Testing

  • Verified that both JabsSettingsDialog and ProjectSettingsDialog open and save settings as expected.
  • Confirmed that session tracking can be enabled/disabled via the new dialog.
  • Ensured that removed utilities are not referenced elsewhere in the codebase.

@gbeane gbeane requested review from keithshep and removed request for keithshep January 22, 2026 16:18
@gbeane gbeane self-assigned this Jan 22, 2026
@gbeane gbeane requested review from bergsalex and keithshep January 22, 2026 16:19
@gbeane gbeane merged commit c25a684 into main Jan 23, 2026
2 checks passed
@gbeane gbeane deleted the refactor-project-settings branch January 23, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants