MULTIARCH-5995: add ppc64le support to the build#768
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughGitHub Actions workflows updated across four files to add the ppc64le architecture to image build platforms and the CLI build matrix, expanding supported platforms alongside amd64, arm64 and s390x. ChangesMulti-architecture build support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-images-for-tag-release.yaml:
- Line 47: The catalogue build job is still missing linux/ppc64le in its
platforms list causing incomplete multi-arch tag releases; update the platforms
value used by the build-catalog step (the line with platforms:
linux/amd64,linux/arm64,linux/s390x,linux/ppc64le) to include linux/ppc64le
(matching the operator and bundle updates) so the build-catalog and any other
job using the same platforms variable publishes ppc64le as well.
In @.github/workflows/upload-cli.yml:
- Around line 25-28: The matrix.exclude block is malformed: remove the array
under goarch and add separate exclude entries for each unsupported darwin
architecture so scalar matching works; specifically update the matrix.exclude to
contain two entries each with goos: darwin and goarch: s390x and goos: darwin
and goarch: ppc64le (instead of a single entry using goarch: [s390x, ppc64le])
so the workflow correctly excludes darwin/s390x and darwin/ppc64le combinations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 051be5dd-af85-409a-a75a-2ef416053cbe
📒 Files selected for processing (4)
.github/workflows/build-coredns-images.yaml.github/workflows/build-images-for-tag-release.yaml.github/workflows/build-images.yaml.github/workflows/upload-cli.yml
Signed-off-by: Rajakumar Battula <rbattula@redhat.com>
| exclude: | ||
| - goos: darwin | ||
| goarch: s390x | ||
| - goos: darwin |
There was a problem hiding this comment.
| - goos: darwin | |
| - goos: linux |
There was a problem hiding this comment.
I am currently excluding GOOS=darwin for power architecture. Would it be fine to change the target OS to linux instead?
# build and publish in parallel: linux/amd64, linux/arm64, linux/s390x, linux/ppc64le, darwin/amd64, darwin/arm64
goos: [linux, darwin]
goarch: [amd64, arm64, s390x, ppc64le]
exclude:
- goos: darwin
goarch: s390x
- goos: darwin
goarch: `ppc64le`
2 participants
MULTIARCH-5995: add ppc64le support to the build
Summary by CodeRabbit