build fixes #4
Open
build fixes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krestol
commented
Jun 9, 2020
| std::unique_ptr<Car> CarFactory::BuildCar(const std::string& color) | ||
| { | ||
| return std::make_unique<Car>(new Car(color)); | ||
| return std::make_unique<Car>(color); |
Krestol
commented
Jun 9, 2020
| { | ||
| } | ||
|
|
||
| Driver::~Driver() |
Owner
Author
There was a problem hiding this comment.
Если в unique_ptr тип, который объявлен предварительно, то требуется реализация деструктора, иначе компилятор генерирует деструктор и ему не "виден" полный тип Car
class Car;
std::unique_ptr car_;
Collaborator
There was a problem hiding this comment.
Вроде понятно, почему не работало, но не понятна логика этой ошибки.
Owner
Author
There was a problem hiding this comment.
если не прояснится после обсуженения процесса подключения файлов и компиляции - посмотрим отдельно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.