Skip to content

Url encode all strings, not just unicode #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guitard0g wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Url encode all strings, not just unicode #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions unirest/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
from poster.encode import multipart_encode
import urllib

def to_utf8(value):
if isinstance(value, unicode):
return urllib.quote_plus(value.encode('utf-8'))

return value
def to_encoded_utf8(value):
return urllib.quote_plus(value.encode('utf-8'))


def _dictionary_encoder(key, dictionary):
result = []
for k, v in dictionary.iteritems():
if type(v) is file:
continue
key = to_utf8(key)
k = to_utf8(k)
v = to_utf8(v)
key = to_encoded_utf8(key)
k = to_encoded_utf8(k)
v = to_encoded_utf8(v)
result.append('{}[{}]={}'.format(key, k, v))

return result
Expand All @@ -35,8 +33,8 @@ def dict2query(dictionary):
nested_query = encoders[v.__class__](k, v)
query += nested_query
else:
key = to_utf8(k)
value = to_utf8(v)
key = to_encoded_utf8(k)
value = to_encoded_utf8(v)
query.append('{}={}'.format(key, value))

return '&'.join(query)
Expand Down