Fix Z2M not replying to OTA requests

[andrei-lazarov]

I saw a Philips Hue bulb spamming OTA requests.

I expected Z2M to reply "No image available", so the bulb would stop asking.
Is this omitted on purpose @Nerivec?

Ctrl+F requested OTA: log.log

[Nerivec]

I checked, it's been like this for over 6 years (I stopped going back after that much 😬).
I think this was intended to de-duplicate. If you allow replies with NO, it might interfere with the first response that could be YES. You'd basically be saying, YES, NO, NO, NO, NO... which no doubt is going to create some troubles.

[andrei-lazarov]

What do you mean the first response could be yes? Isn't that only when attempting to start the update?

[Nerivec]

There's logic on ZH side when checking, depends on several factors. But actually, I think everything replies NO in check path, so, I guess could be fine.

Thing is, we should already be replying NO to the first message, so, if that doesn't shut up the device, I don't think replying to the dupes would stop it either. We'd only end up spamming to reply to spam. 😅

[andrei-lazarov]

I'm sniffing another network and Z2M does actually reply to all devices requesting ota 🤔 Will have to check again