fix(Property): stop setSpecularPower from overwriting roughness#3503
Open
PaulHax wants to merge 1 commit intoKitware:masterfrom
Open
fix(Property): stop setSpecularPower from overwriting roughness#3503PaulHax wants to merge 1 commit intoKitware:masterfrom
PaulHax wants to merge 1 commit intoKitware:masterfrom
Conversation
Drop the setSpecularPower override that also writes roughness, leaving the plain macro.setGet setter behind. Property-bag sets are now commutative with respect to specularPower and roughness, like every other PBR field on vtkProperty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
setSpecularPoweroverride that also writesroughness, leavingthe plain
macro.setGetsetter behind.I think the override existed to auto-derive a PBR
roughnessfor WebGL codethat only set the Phong
specularPower. But Phong and PBR are parallelrendering paths, not a migration — so the bridge silently corrupts
roughnessfor any caller that sets both.