fix(types): correct defaultViewAPI typing#3502
Open
PaulHax wants to merge 1 commit intoKitware:masterfrom
Open
fix(types): correct defaultViewAPI typing#3502PaulHax wants to merge 1 commit intoKitware:masterfrom
PaulHax wants to merge 1 commit intoKitware:masterfrom
Conversation
defaultViewAPI is a string at runtime ('WebGL' / 'WebGPU'), but the types
disagreed:
- DEFAULT_VIEW_API was a const enum with numeric values, so
setDefaultViewAPI(DEFAULT_VIEW_API.WebGPU) would pass 1 and silently
fall back to WebGL.
- IFullScreenRenderWindowInitialValues.defaultViewAPI was typed boolean.
Switch DEFAULT_VIEW_API to a string union (same exported name) and reuse
it. No runtime changes. Related: Kitware#3216, Kitware#3139.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultViewAPIis a string at runtime ('WebGL' / 'WebGPU'), but the typesdisagreed:
DEFAULT_VIEW_APIwas aconst enumwith numeric values, sosetDefaultViewAPI(DEFAULT_VIEW_API.WebGPU)would pass1and silentlyfall back to WebGL.
IFullScreenRenderWindowInitialValues.defaultViewAPIwas typedboolean.Switch
DEFAULT_VIEW_APIto a string union (same exported name) and reuse it.No runtime changes. Related: #3216, #3139.