feat(WebGPU): add ImageResliceMapper#3495
Open
daker wants to merge 2 commits intoKitware:masterfrom
Open
Conversation
38 tasks
sankhesh
requested changes
May 6, 2026
Collaborator
sankhesh
left a comment
sankhesh
left a comment
There was a problem hiding this comment.
Some suggestions and questions. There's a merge conflict too.
I feel a lot of this code is duplicated between opengl and webgpu and should be shared in a common class. But that's not critical for this PR.
daker
force-pushed
the
webgpu-imagereslicemapper
branch
from
63faf08 to
1641c65
Compare
Collaborator
Author
|
@sankhesh I can extract the shared code into common helpers for both WebGL and WebGPU. Do you think that's a good idea ? |
daker
force-pushed
the
webgpu-imagereslicemapper
branch
from
1641c65 to
74487ba
Compare
Collaborator
Yes, it would be a good idea to have common code separated out. |
daker
force-pushed
the
webgpu-imagereslicemapper
branch
from
d5a63f0 to
ab70567
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting