Use fletch #30
Open
Use fletch #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fletch is part of the KWIVER (http://www.kwiver.org/) ecosystem, of which ViViA is also a part. The purpose of fletch is to provide external third-party dependencies required by KWIVER software. Previously, we have had an implicit dependency on fletch, in that some or all of ViViA's third-party dependencies would typically be provided by fletch, with the developer manually specifying their paths. Adding fletch as an optional dependency allows us to discover those dependencies which are provided by fletch without additional user intervention, which makes it easier to configure ViViA.
Member
Author
|
@dstoup, PTAL. Note also that this has a "soft" dependency on Kitware/fletch#384; that PR is necessary for ViViA to find KML from fletch without additional intervention. (I tested on my machine that this, with both PR's, suffices to find KML and libjson, which are the only dependencies I am consuming through fletch.) |
Contributor
|
Looks reasonable. When it lands in gitlab, I can verify that it works against all other packages as well. |
Contributor
|
👍 |
Contributor
|
FWIW, I needed to specify PROJ4_LIBRARY |
Contributor
|
Another pass from scratch. I had to specify (in order) VXL_DIR (fletch not build with VXL), vidtk_DIR, kwiver_DIR, and then PROJ4_LIBRARY. |
Contributor
|
The VXLDIR is troubling as is the PROJ4_DIR. Proj4 is likely a difference
between what fletch exports and what you're expecting, but VXL should be
found assuming you built it in fletch.
…On Fri, Jun 8, 2018 at 5:43 PM, Rusty Blue ***@***.***> wrote:
Another pass from scratch. I had to specify (in order) VXL_DIR (fletch not
build with VXL), vidtk_DIR, kwiver_DIR, and then PROJ4_LIBRARY.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFRAWqaRrdlrhCvqbepfZhfz4f6S-jxbks5t6u_sgaJpZM4UVTfq>
.
--
David Stoup
Principal Engineer
Kitware, Inc.
28 Corporate Drive
Clifton Park, NY. 12065
518-881-4949 (W)
518-312-3946 (M)
518-371-4573 (F)
|
Member
Author
He didn't (as noted in previous comment). I'm also somewhat concerned about PROJ, though I suppose that's a fletch issue rather than a problem with the PR. |
Contributor
|
I suspect the PROJ issues is a mismatch of which variables are being
exposed. PROJ vs PROJ4 maybe?
…On Tue, Jun 12, 2018 at 10:04 AM, Matthew Woehlke ***@***.***> wrote:
VXL should be found assuming you built it in fletch
He didn't (as noted in previous comment). I'm also somewhat concerned
about PROJ, though I suppose that's a fletch issue rather than a problem
with the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFRAWq6g0VfXURcxpTw0RcZ6Sia0BJ2Aks5t78p6gaJpZM4UVTfq>
.
--
David Stoup
Principal Engineer
Kitware, Inc.
28 Corporate Drive
Clifton Park, NY. 12065
518-881-4949 (W)
518-312-3946 (M)
518-371-4573 (F)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fletch is part of the KWIVER ecosystem, of which ViViA is also a part. The purpose of fletch is to provide external third-party dependencies required by KWIVER software. Previously, we have had an implicit dependency on fletch, in that some or all of ViViA's third-party dependencies would typically be provided by fletch, with the developer manually specifying their paths. Adding fletch as an optional dependency allows us to discover those dependencies which are provided by fletch without additional user intervention, which makes it easier to configure ViViA.