Skip to content

Corrections and upgrade from Vue2 to Vue3#877

Open
UlysseDurand wants to merge 26 commits into
Kitware:masterfrom
UlysseDurand:docs-tutoriel-vue3
Open

Corrections and upgrade from Vue2 to Vue3#877
UlysseDurand wants to merge 26 commits into
Kitware:masterfrom
UlysseDurand:docs-tutoriel-vue3

Conversation

@UlysseDurand
Copy link
Copy Markdown
Contributor

This PR depends on Kitware/trame-tutorial#7
because trame and trame-tutorial are referencing one another.

Correct the tutorial and upgrade it from Vue2 to Vue3.

  • Some corrections
    • Code parts from Trame1 were remaining
    • Code parts were not corresponding between doc and examples
  • Change vuetify to vuetify3 in the code
  • Change VSelect's items' text and value
  • Change toggle dark theme mechanism

Comment thread docs/vitepress/guide/tutorial/application.md
Comment thread docs/vitepress/guide/tutorial/application.md Outdated
Comment thread docs/vitepress/guide/tutorial/application.md Outdated
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
Comment thread docs/vitepress/guide/tutorial/paraview.md Outdated
Comment thread docs/vitepress/guide/tutorial/paraview.md Outdated
@jourdain
Copy link
Copy Markdown
Collaborator

I would update to the structure shown here: https://kitware.github.io/trame/examples/core/basics.html#class-for-trame-application

Comment thread docs/vitepress/guide/tutorial/html.md Outdated
Comment thread docs/vitepress/guide/tutorial/html.md Outdated
Comment thread docs/vitepress/guide/tutorial/html.md Outdated
Comment thread docs/vitepress/guide/tutorial/html.md Outdated
Comment thread docs/vitepress/guide/tutorial/html.md Outdated
Comment thread docs/vitepress/guide/tutorial/html.md Outdated
Comment thread docs/vitepress/guide/tutorial/html.md
Comment thread docs/vitepress/guide/tutorial/html.md
Comment thread docs/vitepress/guide/tutorial/paraview.md Outdated
Comment thread docs/vitepress/guide/tutorial/paraview.md Outdated
Comment thread docs/vitepress/guide/tutorial/paraview.md Outdated
@jourdain
Copy link
Copy Markdown
Collaborator

This branch cannot be rebased due to conflicts

Copy link
Copy Markdown
Contributor Author

@UlysseDurand UlysseDurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the examples are updated to use Trame's best practice (like using the TrameApp class).

The corresponding PR in the trame-tutorial repo is the following: Kitware/trame-tutorial#8

Comment thread docs/vitepress/guide/tutorial/application.md Outdated
Comment thread docs/vitepress/guide/tutorial/application.md
Comment thread docs/vitepress/guide/tutorial/application.md Outdated
Comment thread docs/vitepress/guide/tutorial/html.md
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
Comment thread docs/vitepress/guide/tutorial/paraview.md Outdated
Comment thread docs/vitepress/guide/tutorial/paraview.md Outdated
Comment thread docs/vitepress/guide/tutorial/application.md Outdated
Comment thread docs/vitepress/guide/tutorial/application.md Outdated
Comment thread docs/vitepress/guide/tutorial/application.md Outdated
Comment thread docs/vitepress/guide/tutorial/application.md
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
Comment thread docs/vitepress/guide/tutorial/layouts.md Outdated
view = vtk.VtkLocalView(renderWindow)
ctrl.on_server_ready.add(view.update)

class AppCone(TrameApp):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is... But should it be?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose AppLayouts as a better name

Comment thread docs/vitepress/guide/tutorial/setup.md Outdated
UlysseDurand added a commit to UlysseDurand/trame-tutorial that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants