Corrections and upgrade from Vue2 to Vue3#877
Open
UlysseDurand wants to merge 26 commits into
Open
Conversation
jourdain
reviewed
Apr 13, 2026
jourdain
reviewed
Apr 13, 2026
jourdain
reviewed
Apr 13, 2026
jourdain
reviewed
Apr 13, 2026
jourdain
reviewed
Apr 13, 2026
jourdain
reviewed
Apr 13, 2026
jourdain
reviewed
Apr 13, 2026
jourdain
reviewed
Apr 13, 2026
Collaborator
|
I would update to the structure shown here: https://kitware.github.io/trame/examples/core/basics.html#class-for-trame-application |
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
jourdain
reviewed
Apr 28, 2026
Collaborator
|
This branch cannot be rebased due to conflicts |
…to docs-tutoriel-vue3
UlysseDurand
commented
May 5, 2026
Contributor
Author
UlysseDurand
left a comment
There was a problem hiding this comment.
All the examples are updated to use Trame's best practice (like using the TrameApp class).
The corresponding PR in the trame-tutorial repo is the following: Kitware/trame-tutorial#8
- indentation errors - forgot to put self in class function's arguments - self.server.state => self.state - one forgotten layout => self.ui Ref: Kitware#877 (comment) Ref: Kitware#877 (comment) Ref: Kitware#877 (comment) Ref: Kitware#877 (comment) Ref: Kitware#877 (comment) Ref: Kitware#877 (comment) Ref: Kitware#877 (comment)
jourdain
reviewed
May 6, 2026
jourdain
reviewed
May 7, 2026
jourdain
reviewed
May 7, 2026
jourdain
reviewed
May 7, 2026
jourdain
reviewed
May 7, 2026
jourdain
reviewed
May 7, 2026
jourdain
reviewed
May 7, 2026
| view = vtk.VtkLocalView(renderWindow) | ||
| ctrl.on_server_ready.add(view.update) | ||
|
|
||
| class AppCone(TrameApp): |
Collaborator
There was a problem hiding this comment.
I guess it is... But should it be?
Contributor
Author
There was a problem hiding this comment.
I propose AppLayouts as a better name
- trame-tutorial: UlysseDurand/trame-tutorial@5a5c152
- trame: 414df33
jourdain
reviewed
May 7, 2026
…to docs-tutoriel-vue3
UlysseDurand
added a commit
to UlysseDurand/trame-tutorial
that referenced
this pull request
May 11, 2026
UlysseDurand
added a commit
to UlysseDurand/trame-tutorial
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on Kitware/trame-tutorial#7
because trame and trame-tutorial are referencing one another.
Correct the tutorial and upgrade it from Vue2 to Vue3.