Skip to content

Finish making all the examples use best practices #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jourdain merged 5 commits into from
May 12, 2026
Merged

Finish making all the examples use best practices #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
275860f
docs(tutorial): remove view update when server ready
UlysseDurand May 11, 2026
1c39dd5
docs(tutorial): replace **_kwargs with **_
UlysseDurand May 11, 2026
d3c31e0
docs(tutorial): put helper functions that don't need self out of class
UlysseDurand May 11, 2026
5a5c152
docs(tutorial): use AppLayouts instead of AppCone as class name
UlysseDurand May 11, 2026
e433498
docs(tutorial): put better names for the classes in layout examples
UlysseDurand May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions 01_vtk/solution_cone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ def _build_ui(self):
classes="pa-0 fill-height",
):
html_view = vtk.VtkLocalView(renderWindow)
self.ctrl.on_server_ready.add(html_view.update)


# -----------------------------------------------------------------------------
# Main
Expand Down
4 changes: 2 additions & 2 deletions 02_layouts/app_cone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
# Trame
# -----------------------------------------------------------------------------

class AppCone(TrameApp):
class ConeApp(TrameApp):
def __init__(self, server=None):
super().__init__(server)
self._build_ui()
Expand All @@ -67,7 +67,7 @@ def _build_ui(self):
# -----------------------------------------------------------------------------

def main():
app = AppCone()
app = ConeApp()
app.server.start()

if __name__ == "__main__":
Expand Down
4 changes: 2 additions & 2 deletions 02_layouts/solution_FullScreenPage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
# Trame
# -----------------------------------------------------------------------------

class AppCone(TrameApp):
class FullScreenApp(TrameApp):
def __init__(self, server=None):
super().__init__(server)
self._build_ui()
Expand All @@ -65,7 +65,7 @@ def _build_ui(self):
# -----------------------------------------------------------------------------

def main():
app = AppCone()
app = FullScreenApp()
app.server.start()

if __name__ == "__main__":
Expand Down
4 changes: 2 additions & 2 deletions 02_layouts/solution_SinglePage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
# Trame
# -----------------------------------------------------------------------------

class AppCone(TrameApp):
class SinglePageApp(TrameApp):
def __init__(self, server=None):
super().__init__(server)
self._build_ui()
Expand All @@ -67,7 +67,7 @@ def _build_ui(self):
# -----------------------------------------------------------------------------

def main():
app = AppCone()
app = SinglePageApp()
app.server.start()

if __name__ == "__main__":
Expand Down
4 changes: 2 additions & 2 deletions 02_layouts/solution_SinglePageWithDrawer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
# Trame
# -----------------------------------------------------------------------------

class AppCone(TrameApp):
class SinglePageWithDrawerApp(TrameApp):
def __init__(self, server=None):
super().__init__(server)
self._build_ui()
Expand All @@ -67,7 +67,7 @@ def _build_ui(self):
# -----------------------------------------------------------------------------

def main():
app = AppCone()
app = SinglePageWithDrawerApp()
app.server.start()

if __name__ == "__main__":
Expand Down
2 changes: 1 addition & 1 deletion 03_html/solution_final.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def vtk_pipeline(self):
self.renderer.ResetCamera()

@change("resolution")
def update_resolution(self, resolution, **_kwargs):
def update_resolution(self, resolution, **_):
self.cone_source.SetResolution(resolution)
self.ctrl.view_update()

Expand Down
Loading