-
Notifications
You must be signed in to change notification settings - Fork 16
Finish making all the examples use best practice #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ae41918
docs(examples): convert base example using the TrameApp base class
UlysseDurand a3bdcdf
docs(examples): update examples to use TrameApp
UlysseDurand 99c57ae
docs(examples): put const global on the module rather than in the class
UlysseDurand fb4773e
docs(examples): update the example to use the TrameApp class
UlysseDurand 3a3c29d
docs(examples): make the user import trame-components
UlysseDurand 12d3b6d
docs(examples): change **kwargs with **_kwargs because they are unused
UlysseDurand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,29 @@ | ||
| from trame.app import get_server | ||
| from trame.app import TrameApp | ||
| from trame.ui.vuetify3 import SinglePageLayout | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # Get a server to work with | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| server = get_server() | ||
| class App(TrameApp): | ||
| def __init__(self, server=None): | ||
| super().__init__(server) | ||
| self._build_ui() | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # GUI | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| with SinglePageLayout(server) as layout: | ||
| layout.title.set_text("Hello trame") | ||
| def _build_ui(self): | ||
| with SinglePageLayout(self.server) as self.ui: | ||
| self.ui.title.set_text("Hello trame") | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # Main | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| def main(): | ||
| app = App() | ||
| app.server.start() | ||
|
|
||
| if __name__ == "__main__": | ||
| server.start() | ||
| main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,29 @@ | ||
| from trame.app import get_server | ||
| from trame.app import TrameApp | ||
| from trame.ui.vuetify3 import SinglePageLayout | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # Get a server to work with | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| server = get_server() | ||
| class AppCone(TrameApp): | ||
| def __init__(self, server=None): | ||
| super().__init__(server) | ||
| self._build_ui() | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # GUI | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| with SinglePageLayout(server) as layout: | ||
| layout.title.set_text("Hello trame") | ||
| def _build_ui(self): | ||
| with SinglePageLayout(self.server) as self.ui: | ||
| self.ui.title.set_text("Hello trame") | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # Main | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| def main(): | ||
| app = AppCone() | ||
| app.server.start() | ||
|
|
||
| if __name__ == "__main__": | ||
| server.start() | ||
| main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that line is not needed anymore. (self.ctrl.on_server_ready.add)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line removed in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is addressed in
#9