Add project logo update API route#3439
Merged
josephsnyder merged 1 commit intoKitware:masterfrom Feb 26, 2026
Merged
Conversation
Collaborator
Author
|
Closing in favor of including this in a larger change. |
williamjallen
commented
Feb 26, 2026
|
|
||
| ProjectService::setLogo($project, $request->file('logo')); | ||
|
|
||
| return response()->redirectTo(url("/projects/{$project->id}/settings")); |
Collaborator
Author
There was a problem hiding this comment.
This page doesn't exist yet, but will once this route is actually used for anything.
Our infrastructure doesn't support the multi-part requests necessary to handle uploaded files via GraphQL. This commit adds a special `/projects/<id>/logo` POST route which can be used to set the logo for a project.
williamjallen
force-pushed
the
update-project-logo
branch
from
7b735db to
f974b82
Compare
Collaborator
Author
|
Reopening this to help reduce the size of my upcoming project settings page rewrite. |
josephsnyder
approved these changes
Feb 26, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Looks good to me. I haven't tested the actual upload but it makes sense looking forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our infrastructure doesn't support the multi-part requests necessary to handle uploaded files via GraphQL. This commit adds a special
/projects/<id>/logoPOST route which can be used to set the logo for a project.