Add GraphQL Url scalar #3312
Merged
Add GraphQL Url scalar #3312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
graphql-url-scalar
branch
from
8a0229a to
906b623
Compare
williamjallen
force-pushed
the
graphql-url-scalar
branch
from
906b623 to
5e53c8e
Compare
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Do we expect homeUrl to be populated on query or is only for creation?
williamjallen
force-pushed
the
graphql-url-scalar
branch
from
5e53c8e to
36a4d3e
Compare
Collaborator
Author
|
@josephsnyder Fixed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep work for several upcoming cases where having a dedicated URL type will be useful. I also renamed the project
homeurlattribute tohomeUrland added missing project name validation.