Conversation
alteous
commented
Apr 28, 2026
Comment on lines
+2565
to
+2569
| #[serde(default)] | ||
| pub text_shift: Option<f64>, | ||
| /// The desired offset of the dimension line from its initial point. | ||
| #[serde(default)] | ||
| pub line_shift: Option<f64>, |
Contributor
Author
There was a problem hiding this comment.
I haven't decided on a precise definition for these yet.
alteous
commented
Apr 28, 2026
Comment on lines
+786
to
+787
| /// IDs of created projection curves. | ||
| pub curve_ids: Vec<Uuid>, |
Contributor
Author
There was a problem hiding this comment.
This is tentative. Ideally we will have a way of locating a particular feature deterministically in reference to the original geometry but that is easier said than done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.