Skip to content

Austin/legacy csg #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamchalmers merged 2 commits into from
Mar 31, 2026
Merged

Austin/legacy csg #1132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c211fe4
Adds use_legacy flags to CSG operations
austin-j-knutson Mar 26, 2026
47de6de
Adds use_legacy flags to fillet operations
austin-j-knutson Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions modeling-cmds/openapi/api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4436,6 +4436,11 @@
"enum": [
"solid3d_fillet_edge"
]
},
"use_legacy": {
"description": "If true, use the legacy CSG algorithm.",
"default": false,
"type": "boolean"
}
},
"required": [
Expand Down Expand Up @@ -4502,6 +4507,11 @@
"enum": [
"solid3d_cut_edges"
]
},
"use_legacy": {
"description": "If true, use the legacy CSG algorithm.",
"default": false,
"type": "boolean"
}
},
"required": [
Expand Down Expand Up @@ -6262,6 +6272,11 @@
"enum": [
"boolean_union"
]
},
"use_legacy": {
"description": "If true, use the legacy CSG algorithm.",
"default": false,
"type": "boolean"
}
},
"required": [
Expand Down Expand Up @@ -6300,6 +6315,11 @@
"enum": [
"boolean_intersection"
]
},
"use_legacy": {
"description": "If true, use the legacy CSG algorithm.",
"default": false,
"type": "boolean"
}
},
"required": [
Expand Down Expand Up @@ -6346,6 +6366,11 @@
"enum": [
"boolean_subtract"
]
},
"use_legacy": {
"description": "If true, use the legacy CSG algorithm.",
"default": false,
"type": "boolean"
}
},
"required": [
Expand Down Expand Up @@ -6400,6 +6425,11 @@
"enum": [
"boolean_imprint"
]
},
"use_legacy": {
"description": "If true, use the legacy CSG algorithm.",
"default": false,
"type": "boolean"
}
},
"required": [
Expand Down
24 changes: 24 additions & 0 deletions modeling-cmds/src/def_enum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1275,6 +1275,10 @@ define_modeling_cmd_enum! {
#[serde(default)]
#[builder(default)]
pub extra_face_ids: Vec<Uuid>,
/// If true, use the legacy CSG algorithm.
#[serde(default)]
#[builder(default)]
pub use_legacy: bool,
}

/// Cut the list of given edges with the given cut parameters.
Expand Down Expand Up @@ -1309,6 +1313,10 @@ define_modeling_cmd_enum! {
#[serde(default)]
#[builder(default)]
pub extra_face_ids: Vec<Uuid>,
/// If true, use the legacy CSG algorithm.
#[serde(default)]
#[builder(default)]
pub use_legacy: bool,
}

/// Determines whether a brep face is planar and returns its surface-local planar axes if so
Expand Down Expand Up @@ -2224,6 +2232,10 @@ define_modeling_cmd_enum! {
#[serde(default)]
#[builder(default)]
pub separate_bodies: bool,
/// If true, use the legacy CSG algorithm.
#[serde(default)]
#[builder(default)]
pub use_legacy: bool,
/// The maximum acceptable surface gap computed between the joined solids. Must be positive (i.e. greater than zero).
pub tolerance: LengthUnit,
}
Expand All @@ -2246,6 +2258,10 @@ define_modeling_cmd_enum! {
#[serde(default)]
#[builder(default)]
pub separate_bodies: bool,
/// If true, use the legacy CSG algorithm.
#[serde(default)]
#[builder(default)]
pub use_legacy: bool,
/// The maximum acceptable surface gap computed between the joined solids. Must be positive (i.e. greater than zero).
pub tolerance: LengthUnit,
}
Expand All @@ -2271,6 +2287,10 @@ define_modeling_cmd_enum! {
#[serde(default)]
#[builder(default)]
pub separate_bodies: bool,
/// If true, use the legacy CSG algorithm.
#[serde(default)]
#[builder(default)]
pub use_legacy: bool,
/// The maximum acceptable surface gap computed between the target and the solids cut out from it. Must be positive (i.e. greater than zero).
pub tolerance: LengthUnit,
}
Expand All @@ -2297,6 +2317,10 @@ define_modeling_cmd_enum! {
#[serde(default)]
#[builder(default)]
pub separate_bodies: bool,
/// If true, use the legacy CSG algorithm.
#[serde(default)]
#[builder(default)]
pub use_legacy: bool,
/// If true, the provided tool bodies will not be modified
#[serde(default)]
#[builder(default)]
Expand Down
Loading