-
Notifications
You must be signed in to change notification settings - Fork 2
add show seams param to extrude #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| /// If true, seams between the extrusion and the original body will be shown. | ||
| /// Otherwise, seams resulting from the extrusion will be removed where possible. | ||
| #[serde(default)] | ||
| pub merge_coplanar_faces: Option<bool>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field name merge_coplanar_faces contradicts its documented behavior. The name implies that when true, coplanar faces should be merged (hiding seams), but the documentation states "If true, seams between the extrusion and the original body will be shown." This semantic inversion will cause incorrect usage in production.
Fix: Either rename the field to match the behavior or fix the documentation:
// Option 1: Rename field to match documented behavior
pub show_seams: Option<bool>,
// Option 2: Fix documentation to match field name
/// If true, coplanar faces will be merged and seams will be hidden.
/// Otherwise, seams between the extrusion and original body will be shown.
pub merge_coplanar_faces: Option<bool>,| /// If true, seams between the extrusion and the original body will be shown. | |
| /// Otherwise, seams resulting from the extrusion will be removed where possible. | |
| #[serde(default)] | |
| pub merge_coplanar_faces: Option<bool>, | |
| /// If true, coplanar faces will be merged and seams will be hidden. | |
| /// Otherwise, seams between the extrusion and original body will be shown. | |
| #[serde(default)] | |
| pub merge_coplanar_faces: Option<bool>, | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
No description provided.