Fix: Limit Non-Inline Forms per Session

[n7studios]

Summary

This PR fixes an issue where the data-kit-limit-per-session attribute was always being set to true when rendering the non-inline global form. It should correctly reflect the configured setting (true or false).

As a result, the ck_non_inline_form_displayed cookie was also always being set, since setting data-kit-limit-per-session to boolean true or false caused the related JavaScript to trigger unconditionally. This has been resolved by outputting data-kit-limit-per-session as 1 or 0, updating the JS selector accordingly.

This did not break overall functionality (since is_script_output_limited_by_session was always run to check whether all or one form should be output). However, this update ensures the logic and behavior are consistent and cleanly implemented.

Testing

testNonInlineFormLimitPerSessionDoesNotSetCookieWhenDisabled: Test that the ck_non_inline_form_displayed cookie is not set when the non inline form limit per session setting is disabled.

Checklist

• I have written a test and included it in this PR
• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

[github-actions]

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground