Skip to content

Conversation

@n7studios
Copy link
Contributor

Summary

PHPStan's static analysis now only works on PHP 8.0 and higher, due to WordPress' stubs including #[\SensitiveParameter]:

Screenshot 2025-10-29 at 16 15 39

This results in syntax errors in PHP 7.4 and lower:

Screenshot 2025-10-29 at 16 09 46

This PR resolves by running static analysis on PHP 8.0 and higher.
Coding standards are run on PHP 7.2 and higher, to ensure backward compatibility should some users be on extremely old versions of PHP.
End to end tests run have been running on PHP 8.1 since March 2025.

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Oct 29, 2025
@github-actions
Copy link

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground

@n7studios n7studios requested review from a team, corydhmiller and noelherrick and removed request for a team October 29, 2025 13:13
@n7studios n7studios marked this pull request as ready for review October 29, 2025 13:13
@n7studios n7studios merged commit 1c56bb7 into tests-fix-intercom-detection Oct 29, 2025
532 of 560 checks passed
@n7studios
Copy link
Contributor Author

@noelherrick FYI, merged last week. If there are any changes/suggestions, let me know and I can submit a new PR.

@n7studios n7studios deleted the tests-fix-phpstan branch November 11, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants