Skip to content

Tests: Fix Intercom Detection #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n7studios merged 5 commits into from
Oct 29, 2025
Merged

Tests: Fix Intercom Detection #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12111fb
Tests: Fix Intercom Detection
n7studios Oct 29, 2025
12a4d8f
Tests: Run Static Analysis on PHP 8.0+
n7studios Oct 29, 2025
71c33a2
Improve Intercom detection
n7studios Oct 29, 2025
58826b7
Merge branch 'tests-fix-intercom-detection' into tests-fix-phpstan
n7studios Oct 29, 2025
1c56bb7
Merge pull request #943 from Kit/tests-fix-phpstan
n7studios Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,5 @@ jobs:
# Run PHPStan for static analysis.
- name: Run PHPStan Static Analysis
working-directory: ${{ env.PLUGIN_DIR }}
if: ${{ matrix.php-versions == '8.0' || matrix.php-versions == '8.1' || matrix.php-versions == '8.2' || matrix.php-versions == '8.3' || matrix.php-versions == '8.4' }}
run: php vendor/bin/phpstan analyse --memory-limit=1250M
8 changes: 5 additions & 3 deletions tests/EndToEnd/general/plugin-screens/PluginIntercomCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,11 @@ public function testIntercomDisplaysOnSetupWizardScreens(EndToEndTester $I)
*/
private function _seeIntercomScript(EndToEndTester $I)
{
$I->waitForElementVisible('.intercom-lightweight-app-launcher-icon');
$I->click('.intercom-lightweight-app-launcher-icon');
$I->waitForElementVisible('iframe[data-intercom-frame="true"]');
$I->seeInSource("const KIT_INTERCOM_APP_ID = 'e4n3xtxz';");
$I->seeInSource('window.intercomSettings = {');
$I->seeInSource("api_base: 'https://api-iam.intercom.io',");
$I->seeInSource('app_id: KIT_INTERCOM_APP_ID');
$I->seeInSource('(function(){var w=window;var ic=w.Intercom;');
}

/**
Expand Down