Block Editor: Improve Detection #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge/Post/CPT, to determine how to display an error message
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
corydhmiller and
noelherrick
and removed request for
a team
…into improve-divi-tests
noelherrick
approved these changes
Nov 3, 2025
Contributor
noelherrick
left a comment
noelherrick
left a comment
There was a problem hiding this comment.
This could be a helper with a test so that readers can easily understand what you're trying to do by adding an explanatory name, and since wp.editPost doesn't seem to be an API for checking what you're checking, so a bit more subject to change, it would be nice to just update it one place.
6 tasks
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
Block Editor: Add `convertKitGutenbergEnabled` helper
Improve Divi Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When testing for WordPress 6.9 beta, two issues found:
Manually refreshing resources with an invalid/expired access token would result in no error message displaying
A JS error in the browser console.
This PR resolves by:
wp.editPost(only defined if the block editor is active) instead ofwp.blockEditor(which in WordPress 6.9 beta is always defined, regardless of whether the block editor or Classic Editor is used)Changes are in this PR vs. the 6.9 beta PR, to make sure no breaking changes are introduced for those still on the current public version of WordPress 6.8
Testing
Existing tests pass.
Checklist