Refactor POS printers architecture#1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07feeeb18c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (candidate in startIp..endIp) { | ||
| if (emitted >= maxHosts) { | ||
| break |
There was a problem hiding this comment.
Scan local-subnet hosts before enforcing host cap
This loop always starts at the beginning of the CIDR range and stops after maxHosts entries, which means large networks (for example a /16 with local IP 192.168.100.x) only probe 192.168.0.1-192.168.0.254 and never reach the segment where the printer likely resides. Because TcpPrinterDiscovery now defaults to a 254-host cap, TCP discovery can miss reachable printers on valid enterprise/VPN subnets that were previously discoverable when scanning the full range.
Useful? React with 👍 / 👎.
Summary
Verification
flutter analyzeflutter test./gradlew :pos_printers:testDebugUnitTestfromexample/androidflutter build apk --debugfromexampledart pub publish --dry-run(0 warnings)Notes