Add test for tex{Sub}Image2D from HTMLImageElement w/ SVG image w/o natural sizes #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fsoder
force-pushed
the
svg-no-natural-width-height-test
branch
from
2f1253b to
6e1b953
Compare
kainino0x
reviewed
Apr 9, 2025
sdk/tests/conformance/textures/misc/tex-image-svg-image-no-natural-width-and-height.html
Show resolved
Hide resolved
sdk/tests/conformance/textures/misc/tex-image-svg-image-no-natural-width-and-height.html
Show resolved
Hide resolved
kenrussell
approved these changes
Apr 17, 2025
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Thanks for this new test. It passes in Firefox and fails in Chrome without the fix for crbug.com/409203678 . Currently fails in Safari as well; presumably a similar fix is needed there. Merging now and will highlight this to colleagues at Apple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case where an
HTMLImageElementwas referencing an SVG image with no natural width and height wasn't tested.