Remove MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE enum. #3726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this enum from the WEBGL_shader_pixel_local_storage extension, and renumber the remaining enums, both of which have already been done in the underlying ANGLE extension. Remove the use of this enum from the pixel local storage CTS test as well. The new test passes on Chromium with all of these changes made. Associated with https://anglebug.com/40096838 .
lexaknyazev
approved these changes
Mar 25, 2025
Member
lexaknyazev
left a comment
lexaknyazev
left a comment
There was a problem hiding this comment.
Please add asserts for all PLS enums (it could be a follow-up to land this PR faster) like:
shouldBe("pls.MAX_PIXEL_LOCAL_STORAGE_PLANES_WEBGL", "0x96E0");
Member
Author
|
Thanks for your review Alexey; good idea. Added verification of the extension's enums; these pass. |
csmartdalton
approved these changes
Mar 25, 2025
Contributor
csmartdalton
left a comment
csmartdalton
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the test checking the Enum values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this enum from the WEBGL_shader_pixel_local_storage extension, and renumber the remaining enums, both of which have already been done in the underlying ANGLE extension.
Remove the use of this enum from the pixel local storage CTS test as well. The new test passes on Chromium with all of these changes made.
Associated with https://anglebug.com/40096838 .