Note that webgl2 supports TEXTURE_MAX_ANISOTROPY_EXT in sampler entrypoints. #3724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexaknyazev
reviewed
Mar 20, 2025
| <change>Added NoInterfaceObject extended attribute.</change> | ||
| </revision> | ||
| <revision date="2025/03/20"> | ||
| <change>Note that WebGL 2 supports this extension's pnames in sampler entrypoints.</change> |
Member
There was a problem hiding this comment.
nit: Should be "pname" singular because only one of the two extension enums is accepted in sampler entrypoints.
kenrussell
approved these changes
Mar 24, 2025
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Looks good with the small change Alexey suggests.
kdashg
commented
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3718.