Skip to content

Conversation

@spencer-lunarg
Copy link
Contributor

second attempt at #1179 to try and add 2 items in #1174 to see how this all works out before trying to add more

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 603847.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 603862.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1897 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1897 passed.

Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had some nitpicks about the printing of time domains, but then I realized that DumpVkTimeDomainKHR prints key-value pairs, which must be inside of an object. In other words, the OutputPrinter is super easy to get wrong, and probably should be redesigned. Still, it works well enough.

@spencer-lunarg
Copy link
Contributor Author

I thought I had some nitpicks about the printing of time domains, but then I realized that DumpVkTimeDomainKHR prints key-value pairs, which must be inside of an object. In other words, the OutputPrinter is super easy to get wrong, and probably should be redesigned. Still, it works well enough.

Ya, I tried messing with things, it currently prints

vkGetPhysicalDeviceCalibrateableTimeDomainsKHR:
-----------------------------------------------
	pTimeDomains = TIME_DOMAIN_DEVICE_KHR

	pTimeDomains = TIME_DOMAIN_CLOCK_MONOTONIC_KHR

	pTimeDomains = TIME_DOMAIN_CLOCK_MONOTONIC_RAW_KHR

I wanted it to be

vkGetPhysicalDeviceCalibrateableTimeDomainsKHR:
-----------------------------------------------
	pTimeDomains[0] = TIME_DOMAIN_DEVICE_KHR
	pTimeDomains[1] = TIME_DOMAIN_CLOCK_MONOTONIC_KHR
	pTimeDomains[2] = TIME_DOMAIN_CLOCK_MONOTONIC_RAW_KHR

or something better, but couldn't figure out OutputPrinter

@spencer-lunarg spencer-lunarg merged commit 61c4e74 into KhronosGroup:main Dec 17, 2025
18 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-VkCooperativeMatrixPropertiesKHR2 branch December 17, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants