Skip to content

Conversation

@gpx1000
Copy link
Collaborator

@gpx1000 gpx1000 commented Dec 31, 2025

Description

Ray Tracing execution reordering is now public. This sample demonstrates the benefits of SER.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Jan 3, 2026

Does not start for me. I get an error about missing glsl shaders:

[error] Error Message: Failed to open file for reading at path: shaders/ray_tracing_invocation_reorder/glsl/raygen.rgen.spv
[error] Failed when running application Ray tracing invocation reorder

There are some .spv files in that folder, but not for all shaders. Can you add the missing ones?

Also fails when selecting slang, but with another file in the error:

[error] Error Message: Failed to open file for reading at path: shaders/ray_tracing_invocation_reorder/slang/closesthit_normal.rchit.spv

@gpx1000
Copy link
Collaborator Author

gpx1000 commented Jan 3, 2026

Ahh... that must be a left over bug. One of the comments mentioned that GLSL might not be capable of outputting the requisite spv. So I switched to slang and apparently didn't fix the code path. Hang on a sec and I'll update it.

@gpx1000
Copy link
Collaborator Author

gpx1000 commented Jan 3, 2026

Oh, nevermind. I'm an idiot. Wrong PR. Yes, there's some missing shaders, committing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants