Skip to content

Conversation

@SaschaWillems
Copy link
Collaborator

@SaschaWillems SaschaWillems commented Dec 7, 2025

Description

This is an alternative fox for #1443. Instead of adjusting image formats in the C++ side of the code, this uses widely supported features to remove the need to specify format qualifiers at all.

Works with glsl, slang and hlsl.

Fixes #1423

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the approach from #1443.

Besides that: Approved.

@SaschaWillems
Copy link
Collaborator Author

Indeed. It feels odd that the correct way is more verbose. Something that might be worth fixing with future Vulkan versions. I've raised in internal issue.

Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shaderStorageImageWriteWithoutFormat is only supported by more recent hardware for us, but since we don't support ray tracing, it doesn't actually matter.

Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I shouldn't actually approve this since I can't test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation layer warnings on ray tracing samples

4 participants