-
Notifications
You must be signed in to change notification settings - Fork 782
Add graph_constants sample #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add graph_constants sample #1437
Conversation
Signed-off-by: Matthew Sloyan <matthew.sloyan@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the way this sample builds on the previous one.
Maybe, due to the strong ordering, it might be worth to prepend the directories/projects with a number to get that ordering for the noob as well.
Besides that, just two comments...
Note: I did not try to use the emulation layers. Just by code inspection I would approve this PR, though.
samples/extensions/tensor_and_data_graph/graph_constants/graph_constants.cpp
Outdated
Show resolved
Hide resolved
samples/extensions/tensor_and_data_graph/graph_constants/graph_constants.cpp
Show resolved
Hide resolved
SaschaWillems
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great sample and documentation. Works fine for me, I do get several validation errors though:
[error] 222824743 - VUID-vkCreateTensorARM-tensors-09832: vkCreateTensorARM(): tensors feature is not enabled.
The Vulkan spec states: The tensors feature must be enabled (https://docs.vulkan.org/spec/latest/chapters/resources.html#VUID-vkCreateTensorARM-tensors-09832)
[error] 222824743 - VUID-vkCreateTensorARM-tensors-09832: vkCreateTensorARM(): tensors feature is not enabled.
The Vulkan spec states: The tensors feature must be enabled (https://docs.vulkan.org/spec/latest/chapters/resources.html#VUID-vkCreateTensorARM-tensors-09832)
[error] 115483881 - VUID-VkShaderModuleCreateInfo-pCode-08740: vkCreateShaderModule(): SPIR-V Capability GraphARM was declared, but one of the following requirements is required (VkPhysicalDeviceDataGraphFeaturesARM::dataGraph).
The Vulkan spec states: If pCode is a pointer to SPIR-V code, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://docs.vulkan.org/spec/latest/chapters/shaders.html#VUID-VkShaderModuleCreateInfo-pCode-08740)
[error] 167135271 - VUID-vkCreateDataGraphPipelinesARM-dataGraph-09760: vkCreateDataGraphPipelinesARM(): dataGraph feature is not enabled.
The Vulkan spec states: The dataGraph feature must be enabled (https://docs.vulkan.org/spec/latest/chapters/VK_ARM_data_graph/graphs.html#VUID-vkCreateDataGraphPipelinesARM-dataGraph-09760)
[error] 1553436542 - VUID-vkGetDataGraphPipelineSessionMemoryRequirementsARM-bindPoint-09784: vkGetDataGraphPipelineSessionMemoryRequirementsARM(): pInfo->bindPoint (VK_DATA_GRAPH_PIPELINE_SESSION_BIND_POINT_TRANSIENT_ARM) not found in session memory requirements.
The Vulkan spec states: The bindPoint member of pInfo must have been returned as part of a VkDataGraphPipelineSessionBindPointRequirementARM whose bindPointType member is VK_DATA_GRAPH_PIPELINE_SESSION_BIND_POINT_TYPE_MEMORY_ARM by a prior call to vkGetDataGraphPipelineSessionMemoryRequirementsARM for the session member of pInfo (https://docs.vulkan.org/spec/latest/chapters/VK_ARM_data_graph/graphs.html#VUID-vkGetDataGraphPipelineSessionMemoryRequirementsARM-bindPoint-09784)
This is with the latest SDK.
* Fixed possible issue in simple_tensor_and_data sample when running with emulation layer. Signed-off-by: Matthew Sloyan <matthew.sloyan@arm.com>
|
Thank you both for the review! @asuessenbach I have addressed the two comments, thank you for the suggestions. Regarding the ordering the samples with numbers I think this is a great idea and it is something we will add. Would it be okay for us to do this in a follow patch when all samples are merge, just so our fork doesn't diverge too much? @SaschaWillems Glad to hear it, thank you! I haven't seen these on our side, but I will look into it with the latest SDK. The tensor and data graph still isn't fully supported in the public validation layer yet, so this might be the cause. I have also added the guide to downloading and using the ML Extensions for Vulkan Emulation Layer to the description so other can try it out. |
Sure, no problem. |
Description
This sample demonstrates the usage of the VK_ARM_tensors and VK_ARM_data_graph extensions for machine learning inference. These allow you to define a neural network with TOSA operations and then execute inferences using hardware acceleration.
This is the second in a series of samples which introduces graph constants and how to use them in a simple neural network. For example, constants are used in the Convolution 2d operator (commonly used in neural networks). The weights and bias for this operator are fixed values and are stored with the network after training.
The first sample can be found here: #1394
Build & run guide
If you would like to try out this new sample locally, we provide an emulation layer which allows them to run. This can be found here: https://github.com/arm/ai-ml-emulation-layer-for-vulkan. There is also a pre-built Windows package available here: https://www.arm.com/-/media/Files/developer/MLEmulationLayerForVulkan20251107 or you can grab this through our tutorial: https://learn.arm.com/learning-paths/mobile-graphics-and-gaming/vulkan-ml-sample/. This tutorial is for this first sample already merged (simple_tensor_and_data_graph), so it shows you everything needed to try it out. The guide and pre-built is only for Windows though, it does work on Linux, but this will require a manual build from the repository (https://github.com/arm/ai-ml-emulation-layer-for-vulkan). See the build guide for this.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: