This repository was archived by the owner on Jul 19, 2018. It is now read-only.
layers: Check that indirect buffers have the correct usage flag #2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisforbes
force-pushed
the
indirect-buffer-usage
branch
from
32039f4 to
0e13e2e
Compare
Collaborator
Author
|
Formatting issues fixed. |
Contributor
daveh-lunarg
left a comment
daveh-lunarg
left a comment
There was a problem hiding this comment.
The new VU checks look good. Do we need a test to exercise them?
Contributor
jzulauf-lunarg
left a comment
jzulauf-lunarg
left a comment
There was a problem hiding this comment.
Look good so far. Assuming you're pushing layer_validation_tests.cpp updates, yes?
Collaborator
Author
|
Yes, I will add some tests to go with this. |
chrisforbes
force-pushed
the
indirect-buffer-usage
branch
from
0e13e2e to
ee33d96
Compare
Collaborator
|
@chrisforbes, this repository will close for write access on Sunday, 5/13/2018. If it is pushed before that time it will be present in the follow-on Vulkan-ValidationLayers repository on Monday, otherwise a new PR will be required in the new repo. (I think it's acceptable to push the changes if they're OK and to add the tests next week). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2333