Skip to content

Conversation

@mchalain
Copy link

The neon fpu is mandatory for aarch64, and GCC doesn't recognize this option.

Tested with Raspberry Pi 4 64bits

The neon fpu is mandatory for aarch64, and GCC doesn't recognize this
option.
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kiritigowda kiritigowda requested a review from jessegv November 16, 2022 03:58
@kiritigowda kiritigowda self-assigned this Nov 16, 2022
@kiritigowda kiritigowda added the enhancement New feature or request label Nov 16, 2022
@kiritigowda kiritigowda requested a review from Copilot May 23, 2025 20:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the GCC unsupported "-mfpu=neon" flag for aarch64 builds by updating the CMake logic.

  • Removed the condition that set ARCH_BIT to "-mfpu=neon".
  • Now, when no experimental features are enabled, ARCH_BIT is set to "-m64", relying on aarch64’s mandatory neon FPU.
Comments suppressed due to low confidence (1)

cmake_utils/CMake_linux_tools.cmake:31

  • When any of EXPERIMENTAL_USE_VENUM, OPENVX_USE_TILING, or EXPERIMENTAL_USE_OPENCL are enabled, ARCH_BIT is left unset. Please confirm that this behavior is intentional and that a default value is not required for these cases.
if (NOT EXPERIMENTAL_USE_VENUM AND NOT OPENVX_USE_TILING AND NOT EXPERIMENTAL_USE_OPENCL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants