Add additional enum names within already allocated block #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alycm
approved these changes
Mar 14, 2022
Contributor
alycm
left a comment
alycm
left a comment
There was a problem hiding this comment.
LGTM, merging immediately.
Contributor
|
It's fine to have merged this as-is, but I do think these enums are now going to be considered "orphaned": #730 |
Author
Agreed. I'll add an extension block with another PR shortly to fix that. |
Contributor
That's a good point! Hopefully we can get that script into the pre-merge checks in the coming months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.