XML: Add a few missing requires #1444
Conversation
Selection of non contentious changes from KhronosGroup#960. Also see KhronosGroup#1426
| <type name="CL/cl_icd.h"/> | ||
| </require> | ||
| <require> | ||
| <type name="cl_icd_dispatch"/> |
There was a problem hiding this comment.
I was initially surprised to see this, but since cl_icd_dispatch is used by the clInitLayer function I think it makes sense to add it.
FWIW, the cl_layer.h includes cl_icd.h, which contains the definition of the cl_icd_dispatch structure, but listing cl_icd_dispatch here won't hurt anything. The header generation scripts will generate a forward declaration of the structure, but this is still valid after the structure definition.
CC @Kerilk for awareness.
There was a problem hiding this comment.
Missed this one, sorry about that. Would require removing the typedef from icd.h.
kpet
left a comment
kpet
left a comment
There was a problem hiding this comment.
Nice to get forward progress on this.
|
Merging as discussed in the August 19th teleconference. |
4 participants
Selection of non contentious changes from #960. Also see #1426
cl_char,cl_int, ... data typesCL_M_*constantscl_icd_dispatchUnlike #960, it doesn't include
cl_halftype andCL_HALF_*constants. I also movedcl_icd_dispatchinto the group with other types.