OpenCL 3.1 CTS#2690
Open
bashbaug wants to merge 4 commits into
Open
Conversation
franz
suggested changes
May 18, 2026
Contributor
franz
left a comment
There was a problem hiding this comment.
I've been testing with PoCL, and there is one place that still needs patching:
diff --git a/test_conformance/basic/test_enqueued_local_size.cpp b/test_conformance/basic/test_enqueued_local_size.cpp
index 685982d1..2563fb47 100644
--- a/test_conformance/basic/test_enqueued_local_size.cpp
+++ b/test_conformance/basic/test_enqueued_local_size.cpp
@@ -102,7 +102,7 @@ REGISTER_TEST_VERSION(enqueued_local_size, Version(2, 0))
test_error(err, "clCreateBuffer failed.");
std::string cl_std = "-cl-std=CL";
- cl_std += (get_device_cl_version(device) == Version(3, 0)) ? "3.0" : "2.0";
+ cl_std += (get_device_cl_version(device) >= Version(3, 0)) ? "3.0" : "2.0";
err = create_single_kernel_helper(
context, &program[0], &kernel[0], 1, &enqueued_local_size_1d_code,
"test_enqueued_local_size_1d", cl_std.c_str());Also, I've noticed that the test for event-complete-is-sync-point is missing - is that intentional ?
Contributor
Author
Yes, this is intentional, see: KhronosGroup/OpenCL-Docs#1558 |
Contributor
Author
Thanks! Fixed by ea26359. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for OpenCL 3.1.