fix(images/kernel_read_write): align mem flags between format query a…#2682
Open
Lurie97 wants to merge 1 commit into
Open
fix(images/kernel_read_write): align mem flags between format query a…#2682Lurie97 wants to merge 1 commit into
Lurie97 wants to merge 1 commit into
Conversation
Lurie97
force-pushed
the
fix_kernel_read_write
branch
from
3cdf771 to
e8d9acc
Compare
…nd image creation The format query in test_loops.cpp uses CL_MEM_WRITE_ONLY, but test_write_*.cpp creates images with both CL_MEM_WRITE_ONLY and CL_MEM_READ_WRITE flags. This causes test failures for formats that are only supported with WRITE_ONLY flag (e.g., CL_RGB + CL_SIGNED_INT8). Solution: - Change write_only_mem_flag_types array from 2 elements to 1 element - Only test CL_MEM_WRITE_ONLY flag for kWriteTests - CL_MEM_READ_WRITE is already covered by kReadWriteTests which uses read_write kernel and queries formats with CL_MEM_KERNEL_READ_AND_WRITE Signed-off-by: jiajia Qian <jiajia.qian@nxp.com>
Author
|
Hi @franz @karolherbst, could you please help review this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd image creation
The format query in test_loops.cpp uses CL_MEM_WRITE_ONLY, but test_write_*.cpp creates images with both CL_MEM_WRITE_ONLY and CL_MEM_READ_WRITE flags. This causes test failures for formats that are only supported with WRITE_ONLY flag (e.g., CL_RGB + CL_SIGNED_INT8).
Solution: