Skip to content

Conversation

@pdaniell-nv
Copy link
Contributor

Extension specification for GLSL_EXT_uniform_buffer_unsized_array, which is referenced by the Vulkan VK_EXT_shader_uniform_buffer_unsized_array extension.

@pdaniell-nv pdaniell-nv added this to the Needs Approval milestone Oct 30, 2025
@pdaniell-nv pdaniell-nv requested a review from gnl21 October 30, 2025 15:11
@pdaniell-nv
Copy link
Contributor Author

@gnl21 could you review and merge if you're happy with this. Thanks.

the value returned will not be a constant expression and will be
determined at runtime based on the size of the buffer object providing storage
for the block. Such arrays are runtime sized. For runtime-sized arrays,
the value returned by the length() method will be undefined if the array is contained

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says "undefined" here for .length() but further down it says "will result in a compile-time error if used". Should this use the latter wording instead? It will be a compile-time error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pre-existing language that refers to SSBOs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks. LGTM then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Vulkan Functionality applies to Vulkan API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants