Skip to content

Conversation

@tramora
Copy link
Collaborator

@tramora tramora commented Jan 13, 2026

Fixes #528


TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora tramora requested review from folmos-at-orange and popescu-v and removed request for folmos-at-orange January 13, 2026 16:56
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments; expecially:

  • use fs
  • update test.

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor issues (see the comments).

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pandas 3.0 is out since January 21st, 2026 and contains breaking changes. Hence, it is automatically installed and entails failures in the CI.

Hence, we need to put upper bound at 2.3 on Pandas in pyproject.toml and packaging/conda/meta.yaml.

@tramora
Copy link
Collaborator Author

tramora commented Jan 22, 2026

Pandas 3.0 is out since January 21st, 2026 and contains breaking changes. Hence, it is automatically installed and entails failures in the CI.

Hence, we need to put upper bound at 2.3 on Pandas in pyproject.toml and packaging/conda/meta.yaml.

This was fixed and the CI turned green

@tramora tramora requested a review from popescu-v January 22, 2026 16:04
CHANGELOG.md Outdated
## Unreleased

## Fixed
- (General) Preventing installation of `pandas` 3.x because of breaking changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave this out of the CHANGELOG, because it is a transient problem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to the changelog (see the comment).

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tramora tramora merged commit a03bba3 into dev Jan 23, 2026
77 checks passed
@tramora tramora deleted the 528-remote-home branch January 23, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HOME containing a remote path is incorrectly parsed

4 participants