-
Notifications
You must be signed in to change notification settings - Fork 2
Fix a buggy samples_dir path construction when HOME contains a remote path #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
popescu-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments; expecially:
- use
fs - update test.
0ac4eec to
6ddb0a8
Compare
6ddb0a8 to
a577839
Compare
popescu-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor issues (see the comments).
a577839 to
1590a04
Compare
popescu-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pandas 3.0 is out since January 21st, 2026 and contains breaking changes. Hence, it is automatically installed and entails failures in the CI.
Hence, we need to put upper bound at 2.3 on Pandas in pyproject.toml and packaging/conda/meta.yaml.
b01397f to
9cf6547
Compare
This was fixed and the CI turned green |
CHANGELOG.md
Outdated
| ## Unreleased | ||
|
|
||
| ## Fixed | ||
| - (General) Preventing installation of `pandas` 3.x because of breaking changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave this out of the CHANGELOG, because it is a transient problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
popescu-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change to the changelog (see the comment).
f8c2e20 to
9942c3e
Compare
popescu-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #528
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html